feat/BILL-CPC-933_Implement_Button_To_Calculate_Bill_With_Tax #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM374 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
HennaCH
changed the title
drallo22
previously approved these changes
Oct 22, 2023
| @@ -42,6 +42,8 @@ <h5>Due Date: <strong>{{$ctrl.bills.dueDate}}</strong></h5> | |||
| <hr> | |||
| <br> | |||
| <h5>Final Amount Due: {{$ctrl.bills.amount}}</h5> | |||
| <h5 ng-if="show">Final Amount Including Taxes: {{$ctrl.bills.taxedAmount}}</h5> | |||
| <button class="newBtn btn btn-primary" ng-click="show = !show"> {{show? "Hide amount including taxes" : "Show amount including taxes"}}</button> | |||
There was a problem hiding this comment.
You also could have done this by crating a style class that is hidden, and then when the button is clicked the style class is then shown! Just a small change, either way works well!
There was a problem hiding this comment.
Ok, I will try your suggestion !
ebond07
previously approved these changes
Oct 22, 2023
Comment on lines
15
to
16
| //Mono<BillResponseDTO> getTaxedAmountByBillIdAndBillAmount(String billId, Double amount); | ||
|
|
There was a problem hiding this comment.
Is this left here so that eventually it will be implemented in the service impl? If not I don't think it would be a bad idea to get rid of commented out lines that we aren't using.
ebond07
approved these changes
Oct 24, 2023
drallo22
approved these changes
Oct 24, 2023
…ate_Bill_With_Tax
HennaCH
deleted the
feat/BILL-CPC-933_Implement_Button_To_Calculate_Bill_With_Tax
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-933
Context:
We need to see the amount to pay including taxes
Changes
Before and After UI (Required for UI-impacting PRs)
Before
After
Dev notes (Optional)